Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Exclude NKP-Pulse from Airgapped builds. #2961

Merged
merged 2 commits into from
Dec 19, 2024
Merged

chore: Exclude NKP-Pulse from Airgapped builds. #2961

merged 2 commits into from
Dec 19, 2024

Conversation

kaiwalyajoshi
Copy link
Contributor

What problem does this PR solve?:

NKP-Pulse shouldn't be included in air-gapped builds (similar to AI-Navigator).
This PR follows up on #2957 to exclude NKP-Pulse from airgapped builds.

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-103329

Special notes for your reviewer:
Corresponding PRs:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2024
@kaiwalyajoshi kaiwalyajoshi added ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review labels Dec 19, 2024
@coveralls
Copy link

coveralls commented Dec 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12422495536

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12420169807: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

@kaiwalyajoshi kaiwalyajoshi force-pushed the kjoshi/exclude-pulse-airgapped branch from d7b7ae8 to 75c5b76 Compare December 19, 2024 23:27
msdolbey
msdolbey approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Nice

@kaiwalyajoshi kaiwalyajoshi merged commit 4a12265 into main Dec 19, 2024
18 checks passed
@kaiwalyajoshi kaiwalyajoshi deleted the kjoshi/exclude-pulse-airgapped branch December 19, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdolbey msdolbey msdolbey approved these changes

@mikolajb mikolajb mikolajb approved these changes

@asekretenko asekretenko Awaiting requested review from asekretenko

Assignees
No one assigned
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiwalyajoshi @coveralls @mikolajb @msdolbey